Conversation
Member
|
Thanks @ablack3 ! Would you mind adding some comments to the code to explain why this is necessary? Else I think a year from now we'll all be scratching our heads when we see it ;-) |
Collaborator
Author
|
Hi @schuemie yes good idea. I've added a few comments. It looks like the tests fail because the iris test database is not reachable. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #325 +/- ##
===========================================
+ Coverage 56.33% 56.36% +0.02%
===========================================
Files 16 16
Lines 2721 2725 +4
===========================================
+ Hits 1533 1536 +3
- Misses 1188 1189 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
schuemie
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this branch the issue with duckdb dplyr sql translation seems fixed. #324
Created on 2025-12-30 with reprex v2.1.1