Skip to content

Fix bug in NA calculation#654

Open
katy-sadowski wants to merge 2 commits intodevelopfrom
katy__na_bug
Open

Fix bug in NA calculation#654
katy-sadowski wants to merge 2 commits intodevelopfrom
katy__na_bug

Conversation

@katy-sadowski
Copy link
Collaborator

See #651 - many users reporting an issue relating to calculation of NA status. Seems to result from cdmTable and measureValueCompleteness results being missing for CONDITION_OCCURRENCE.

I still don't know why so many people just started having this issue, but I think this fix should address the specific error. I'd still like to understand if there's a deeper issue that suddenly caused this state to appear for several users (myself included).

@katy-sadowski katy-sadowski changed the base branch from main to develop January 30, 2026 02:29
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.10%. Comparing base (5609499) to head (a016e0f).

Files with missing lines Patch % Lines
R/calculateNotApplicableStatus.R 85.71% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #654      +/-   ##
===========================================
- Coverage    87.14%   87.10%   -0.05%     
===========================================
  Files           17       17              
  Lines         1066     1078      +12     
===========================================
+ Hits           929      939      +10     
- Misses         137      139       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant