Redefine field_plausible_during_life and field_plausible_temporal_after#454
Closed
MaximMoinat wants to merge 8 commits intodevelopfrom
Closed
Redefine field_plausible_during_life and field_plausible_temporal_after#454MaximMoinat wants to merge 8 commits intodevelopfrom
MaximMoinat wants to merge 8 commits intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #454 +/- ##
========================================
Coverage 86.42% 86.42%
========================================
Files 16 16
Lines 884 884
========================================
Hits 764 764
Misses 120 120 ☔ View full report in Codecov by Sentry. |
14b7ec4 to
bd4f2bb
Compare
Collaborator
Author
|
To the reviewer(s): this check changes the meaning of both checks, making results harder to compare between DQD versions. It might be better to create completely new checks (e.g. into three new checks: |
dimshitc
reviewed
Dec 15, 2023
Collaborator
dimshitc
left a comment
There was a problem hiding this comment.
All good, but we agreed to split it into 3 checks. So, please let me know when this is done, and I'll approve the PR.
2 tasks
Collaborator
Author
|
Closing this PR, reimplemented as three new checks in #516 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redefine plausibleDuringLife, to be in line with the name; checking for events that happen before birth OR after death, instead of only checking for events after death.
Removes the date of birth check from field_plausible_temporal_after.sql.
Lastly, the date of birth derivation logic has changed. It is taken either from birth_datetime if available, otherwise calculated from year/month/day_of_birth, taking 1st if month/day not available (instead of using July 1st). See #445.