plotCompareDqdResults and plotConceptCoverage#252
Open
MaximMoinat wants to merge 70 commits intoOHDSI:mainfrom
Open
plotCompareDqdResults and plotConceptCoverage#252MaximMoinat wants to merge 70 commits intoOHDSI:mainfrom
MaximMoinat wants to merge 70 commits intoOHDSI:mainfrom
Conversation
Merge branch 'edit_thresholds' of https://github.com/thehyve/DataQualityDashboard into edit_thresholds # Conflicts: # extras/edit_thresholds/README.md
Mapping coverage plot
Compare DQD
Edit thresholds
Co-authored-by: Maxim Moinat <maxim@thehyve.nl>
Co-authored-by: Maxim Moinat <maxim@thehyve.nl>
Co-authored-by: Maxim Moinat <maxim@thehyve.nl>
Co-authored-by: Maxim Moinat <maxim@thehyve.nl>
Co-authored-by: Maxim Moinat <maxim@thehyve.nl>
Utilities clean up
fixed bug in the implicit output folder manipulation
Fixing typos - semicolons accidentally replaced with commas, some trailing commas deleted.
Adding flowsheet measurement plausible values
Co-authored-by: Elena <35764654+egarcialara@users.noreply.github.com>
Co-authored-by: Elena <35764654+egarcialara@users.noreply.github.com>
Incorporate compare and coverage into easy to use functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two utility functions that can be called after generating the DQD results:
DataQualityDashboard::plotCompareDqdResults(dqd_json_old, dqd_json_new)DataQualityDashboard::plotConceptCoverage(dqd_json_file)Described in the OHDSI 2021 collaborator showcase (points 2 and 3): https://www.ohdsi.org/2021-global-symposium-showcase-67/