separate dependency-failure from package-failure#44
Open
gasche wants to merge 1 commit intoOCamlPro:masterfrom
Open
separate dependency-failure from package-failure#44gasche wants to merge 1 commit intoOCamlPro:masterfrom
gasche wants to merge 1 commit intoOCamlPro:masterfrom
Conversation
Contributor
Author
|
Note: the colors were previously
as I was doing the change I also moved BadDeps to white (I mostly don't care), so the new color scheme is:
I could move BadDeps back to some intermediary color (yellow ?) if asked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently opam-builder considers that any package whose dependencies are installable should be buildable, and counts any failure as just a Failure of the package to build. This PR separates two status, Failure, when the package itself fails to build, and DepFail (Dependency Failure), when one of the dependencies failed to build. Separating the two in the web interface really matter if we want to locate the packages that have to be fixed first -- currently I waste time going through Failure that are in fact DepFail, and (for now) require no action on my part.
Fixes #5.