Open
Conversation
mcarans
approved these changes
Apr 29, 2024
Contributor
mcarans
left a comment
mcarans
left a comment
There was a problem hiding this comment.
Looks good to me. I've left a few comments for you to consider.
| account: str, | ||
| container: str, | ||
| key: str, | ||
| data: None, |
Contributor
There was a problem hiding this comment.
It can be helpful to users of the function specify a type hint eg. Optional[Dict] if it can be None or a dictionary
| account (str): Storage account to access the blob | ||
| container (str): Container to download from | ||
| key (str): Key to access the blob | ||
| blob (str): Name of the blob to be downloaded. If empty, then it is assumed to download |
Contributor
There was a problem hiding this comment.
Since the default is None, the type should be Optional[str]
| "If-None-Match": "", | ||
| "If-Unmodified-Since": "", | ||
| "Range": "", | ||
| "CanonicalizedHeaders": "x-ms-date:" |
Contributor
There was a problem hiding this comment.
Consider using f-strings for this and other cases of concatenating strings
Author
|
I am going to put this PR on hold for now and getting back to it next month. |
Contributor
|
@isatotun Is it ok to close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a basic working piece for the upload and download of blob files into and from azure.
The methods here will be extended but for now in terms of testing some development pipelines this should suffice.