[MIG] stock_request: Migration to 19.0

[kirca]

No description provided.

[AaronHForgeFlow]

I did a functional review. It works well but I found an issue, that is probably affecting other versions of the module:

Steps to Reproduce

Setup:

Create a custom route to internally supply a location in the warehouse:

Rule 1: Pull from Location A to Location B (Procure Method: "Take from stock, if unavailable, trigger another rule")

Rule 2: Buy to Location A (standard Buy rule )

Create a product with this that route enabled
Set stock quantity in Location A to 3 units

Reproduce:

Create a stock request for 10 units to Location B
Confirm the stock request

Expected Result:

Internal transfer created for 3 units (available stock)
Purchase Order created for 7 units (shortage)
PO line linked to stock request via stock_request_ids

Actual Result:

• Internal transfer created for 3 units
• Purchase Order created for 7 units
• PO line NOT linked to stock request --> This is not happening

I tested it together with the stock_request_purchase module. However, because potentially there it could be more chained rules than the scenario above I consider it is not harmful to include the code in the base module. I can propose the 'fix' to a previous version if you prefer that.

[AaronHForgeFlow]

Can you add this code here? Reason explained in the review main comment.

    def _prepare_procurement_values(self):
        """Propagate stock_request_ids when creating procurement from moves"""
        values = super()._prepare_procurement_values()
        if self.stock_request_ids:
            values["stock_request_id"] = self.stock_request_ids[0].id

        return values

[AaronHForgeFlow]

Suggested change

	for allocation in request.allocation_ids:
	if allocation.stock_move_id.picking_code == "incoming":
	incoming_qty += allocation.allocated_product_qty
	else:
	other_qty += allocation.allocated_product_qty
	for allocation in request.allocation_ids:
	if allocation.stock_move_id.move_dest_ids:
	continue
	if allocation.stock_move_id.picking_code == "incoming":
	incoming_qty += allocation.allocated_product_qty
	else:
	other_qty += allocation.allocated_product_qty

Not due to this PR, but an issue that is present in v18 as well. Stock request qty_done was incorrectly calculated when using multi-step routes (e.g., Stock → Transit → Destination) because intermediate moves in the chain were counted, causing them to cancel each other out.
Solution: Skip moves that have move_dest_ids (intermediate moves in chain), only count the final destination move.

[kirca]

Hello @AaronHForgeFlow , thank you for the review!

The issue(s) you are describing are valid but I'm wondering if the second issue (counting allocations of the intermediate moves) is not result of your fix to the first issue (propagating the stock_request_id in case of multi step routes). If we propagate the stock_request_id this will mean an allocation will be created for all moves in the chain https://github.com/OCA/stock-logistics-request/blob/18.0/stock_request/models/stock_rule.py#L31. So this will create links to the stock_request which is then causing the issue in the _compute_qty method (could be in other places too). I'm wondering if this should be checked by the repo/module maintainers first. Perhaps it is best to track this in a separate PR and let others review it (including me!).

[AaronHForgeFlow]

@kirca I see, the fixes proposed have some side effects. Perhaps we can discard them for now but put them in the readme as known issues.

[kirca]

@AaronHForgeFlow I've updated the roadmap with the issue and a possible solution

[AaronHForgeFlow]

Functional ok!