auth_admin_passkey to new API

[rvalyi]

cc @legalsylvain
@pedrobaeza sorry I didn't master the API wizardry enough, but I finally got it an migrated res_users.py too. I amended the push and pushed again.
Travis didn't start in the old PR so I closed it an created a new one.

[pedrobaeza]

Thanks for the changes. Please check Travis errors (some are related, although I think the main build isn't).

[rvalyi]

@pedrobaeza I amended the commit and fixed the style. As you can see the Travis error on fetchmail is unrelated, so tests are passing.

[rvalyi]

@pedrobaeza hey I won the heisenbug Travis lottery after a few attempts: all green. So if you could review again... The idea is I migrated the API just before an other v9 PR port and also the feature extension we discussed a year ago...

[pedrobaeza]

This can be also imported in openerp namespace directly

[rvalyi]

@pedrobaeza done. How does it look now?

[pedrobaeza]

Thanks for the changes.

👍

[lasley]

LGTM as well 👍

[legalsylvain]

Hi,
Why did you removed safe_eval here, and not here :
8025a5d#diff-70199c6feb20b249a2794f26b51b5105R35

[legalsylvain]

Hi raphael,
Thanks a lot for porting this module. Just one question in the first commit about safe_eval.
Otherwise LGTM. Thanks !

[sbidoul]

@rvalyi since you are busy refactoring this module, do you have an opinion on #529 ?

[dvdhinesh]

I am facing an Internal server error when testing this PR on runbot.

Issue:
When a user login with the same password as admin, it tries to send an email for intimation.

Traceback:

Traceback (most recent call last):
result = dispatch(method, params)
return fn(*params)
return res_users.authenticate(db, login, password, user_agent_env)
self._send_email_same_password(cr, login)
return old_api(self, *args, **kwargs)
TypeError: _send_email_same_password() takes exactly 2 arguments (3 given)

PR available @: akretion#6