[18.0][IMP] purchase_last_price_info: improve field name for last purchase currency rate#2964
Open
JordiMForgeFlow wants to merge 2 commits intoOCA:18.0from
Open
Conversation
Contributor
|
Hi @LoisRForgeFlow, |
JordiMForgeFlow
force-pushed
the
18.0-imp-purchase_last_price_info-currency_rate_label
branch
from
eea2da8 to
5abec96
Compare
JordiMForgeFlow
force-pushed
the
18.0-imp-purchase_last_price_info-currency_rate_label
branch
from
5abec96 to
58de286
Compare
JordiMForgeFlow
changed the title
JordiMForgeFlow
force-pushed
the
18.0-imp-purchase_last_price_info-currency_rate_label
branch
from
82833f7 to
aa1d14a
Compare
A change has been made to how the last purchase date was filtered, as in some cases it was not taking the last date but the first, so I have modified how the date is filtered.
JordiMForgeFlow
force-pushed
the
18.0-imp-purchase_last_price_info-currency_rate_label
branch
from
aa1d14a to
168ee14
Compare
Contributor
|
For reference, the second commit is fwporting this #2822 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The field is showing the currency rate of the last purchase, the wording was a bit confusing IMHO
Also FW of #2822