[MIG][9.0]product supplierinfo for customer by AaronHForgeFlow · Pull Request #287 · OCA/product-attribute

AaronHForgeFlow · 2017-07-31T13:47:39Z

Use product supplier info also for customers

This modules allows to use supplier info structure, available in Inventory tab of the product form, also for defining customer information, allowing to define prices per customer and product.

No extra features are added in this Pull Request.

As discussed here: #236 The module product_customer_code is deprecated in favor of this one.

MiquelRForgeFlow

LGTM

pedrobaeza · 2018-06-28T14:54:06Z

Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

…option

…elds

…lder.

…tomer: Complete README.

MiquelRForgeFlow · 2018-06-28T18:27:36Z

@pedrobaeza done

pedrobaeza · 2018-06-28T19:54:50Z

product_supplierinfo_for_customer/README.rst

+Configuration
+=============
+
+For these prices to be used in sale prices calculations, you will have


Is this feature still there?

pedrobaeza · 2018-06-28T19:55:16Z

product_supplierinfo_for_customer/README.rst

+
+The product code / product name specified for the customer can be reflected
+on the sale orders using module `product_supplierinfo_for_customer_sale
+<https://github.com/OCA/product-attribute/tree/8.0/product_supplierinfo_for_customer_sale>`_


s/8.0/9.0 You can use the new README by fragments system for avoiding to change this.

that's not my PR. I will do fragments maybe in new modules for v11 or v12

Then the version should be corrected. You can apply the system the same for <v11. It's more comfortable IMO, but as you prefer.

the version has been corrected.

And I am not comfortable with the fragments yet 🙄

pedrobaeza · 2018-06-28T19:55:44Z

product_supplierinfo_for_customer/README.rst

+Contributors
+------------
+* Oihane Crucelaegui <oihanecrucelaegi@avanzosc.es>
+* Pedro M. Baeza <pedro.baeza@serviciosbaeza.com>


Put * Tecnativa - Pedro M. Baeza instead

pedrobaeza · 2018-06-28T19:55:56Z

product_supplierinfo_for_customer/__init__.py

@@ -0,0 +1,5 @@
+# -*- coding: utf-8 -*-
+##############################################################################


Change this old style header to the proper one

pedrobaeza · 2018-06-28T19:56:09Z

product_supplierinfo_for_customer/__openerp__.py

+{
+    "name": "Use product supplier info for customers too",
+    "version": "9.0.1.0.0",
+    "author": "OdooMRP team, "


You can remove OdooMRP team

MiquelRForgeFlow · 2018-07-02T16:25:26Z

@elicoidal @oihane

elicoidal

some details

elicoidal · 2018-07-03T01:05:29Z

product_multi_category/README.rst

-Open ERP connector
-**Note: The additional categories are only for classification and does
-not affect other operations
+* Note: This module was built generically but in focus of the Magento


Note: * This module was built generically but in focus of the Magento OpenERP connector * The additional categories are only for classification and do not affect other operations

elicoidal · 2018-07-03T01:06:30Z

product_supplierinfo_for_customer/README.rst

+
+* Product prices through this method are only guaranteed on the standard sale
+  order workflow. Other custom flows maybe don't reflect the price.
+* The minimum quantity will not also be applied on sale orders.


Why? in which case?

Because it is not implemented in this PR. In v10 there's an option to create pricelist based on supplierinfo table but not here.

Could you add a simple explanation in the README?

elicoidal · 2018-07-03T01:06:53Z

product_supplierinfo_for_customer/__openerp__.py

+    "category": "Sales Management",
+    "license": 'AGPL-3',
+    "depends": [
+        "base",


do you really need this?

I think so, because it's inheriting from res.partner

product is already adding the dependency IMO.
Not hurting but I usually prefer to have the strictly necessary

elicoidal · 2018-07-03T01:07:08Z

product_supplierinfo_for_customer/demo/product_demo.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>


add copyright

elicoidal · 2018-07-03T01:07:54Z

product_supplierinfo_for_customer/i18n/de.po

@@ -0,0 +1,128 @@
+# Translation of Odoo Server.


With the new weblate server you are not supposed to add .po files unless this is the first time.
Are you sure?

Transifex added this one, do we have to delete it?

I am not sure: @sbidoul ?

Since it's a migration, it also the first time the .po file appear on this branch. So you can keep them, there is no risk of conflict.

elicoidal · 2018-07-03T01:08:15Z

product_supplierinfo_for_customer/models/__init__.py

@@ -0,0 +1,7 @@
+# -*- coding: utf-8 -*-
+##############################################################################


please use standard short headers

elicoidal · 2018-07-03T01:08:55Z

product_supplierinfo_for_customer/tests/test_product_supplierinfo_for_customer.py

+            self.product.id, 1, partner=self.customer.id)
+        self.assertTrue(
+            price_unit.get(self.pricelist.id, False),
+            "Error: Price unit not found for customer")


MiquelRForgeFlow · 2018-07-03T11:34:58Z

@elicoidal comments attended

rafaelbn · 2019-09-04T23:52:15Z

So @aheficent @mreficent this could be merged? @pedrobaeza could you unblock this one?

AaronHForgeFlow · 2019-09-05T05:24:11Z

@rafaelbn I am not sure, needs to be reviewed. I think the code here is not even to what it is in v10

pedrobaeza mentioned this pull request Jul 31, 2017

Migration to version 9.0 #100

Closed

37 tasks

AaronHForgeFlow force-pushed the 9.0-mig-product_supplierinfo_for_customer branch from d87d149 to b5c009a Compare July 31, 2017 15:18

AaronHForgeFlow force-pushed the 9.0-mig-product_supplierinfo_for_customer branch from b5c009a to a63f460 Compare August 16, 2017 14:22

AaronHForgeFlow force-pushed the 9.0-mig-product_supplierinfo_for_customer branch from ae5fd49 to 4f34d6f Compare September 8, 2017 15:27

AaronHForgeFlow force-pushed the 9.0-mig-product_supplierinfo_for_customer branch from 4f34d6f to 2a03f30 Compare September 29, 2017 13:56

MiquelRForgeFlow approved these changes Jun 28, 2018

View reviewed changes

oihane and others added 12 commits June 28, 2018 17:39

<product_supplierinfo_for_customer>

deaa779

product_supplierinfo_for_customer: Views and documentation

48fda6d

Related to OCA#638

8f4c3b1

Slovene translations of odoomrp modules

97bd663

product_supplierinfo_for_customer: Avoid side effects + improve README

3c3f4e3

<product_supplierinfo_for_customer> Create 'customer' type from menu …

2fb031e

…option

<product_supplierinfo_for_customer> Added know issue with computed fi…

3438b5c

…elds

product_supplierinfo_for_customer: Create "demo" data, and "tests" fo…

cc00eca

…lder.

license target link

127abd4

OCA as author added

1a190ca

OCA Transbot updated translations from Transifex

a7f7a66

product_customer_code: New README. [REF] product_supplierinfo_for_cus…

9d8146c

…tomer: Complete README.

MiquelRForgeFlow force-pushed the 9.0-mig-product_supplierinfo_for_customer branch from 2a03f30 to 8e2e814 Compare June 28, 2018 15:39

pedrobaeza added this to the 9.0 milestone Jun 28, 2018

pedrobaeza requested changes Jun 28, 2018

View reviewed changes

MiquelRForgeFlow force-pushed the 9.0-mig-product_supplierinfo_for_customer branch from e1a1ac8 to 9818e89 Compare June 29, 2018 10:43

elicoidal reviewed Jul 3, 2018

View reviewed changes

AaronHForgeFlow force-pushed the 9.0-mig-product_supplierinfo_for_customer branch 2 times, most recently from a27f9af to 5321d85 Compare July 3, 2018 07:36

MiquelRForgeFlow force-pushed the 9.0-mig-product_supplierinfo_for_customer branch 2 times, most recently from 1694b1a to 2bab28e Compare July 3, 2018 10:28

MiquelRForgeFlow force-pushed the 9.0-mig-product_supplierinfo_for_customer branch from 2bab28e to 30607a5 Compare July 3, 2018 11:49

[MIG]product_supplierinfo_for_customer to v9

b8e8644

MiquelRForgeFlow force-pushed the 9.0-mig-product_supplierinfo_for_customer branch from 30607a5 to e1e6007 Compare July 3, 2018 11:59

[FIX] product_multi_category: E7901 error pylint in readme

39de341

MiquelRForgeFlow force-pushed the 9.0-mig-product_supplierinfo_for_customer branch from e1e6007 to 39de341 Compare July 3, 2018 14:22

AaronHForgeFlow closed this Dec 13, 2019

		@@ -0,0 +1,5 @@
		# -- coding: utf-8 --
		##############################################################################

		@@ -0,0 +1,12 @@
		<?xml version="1.0" encoding="UTF-8"?>
		<openerp>

		@@ -0,0 +1,7 @@
		# -- coding: utf-8 --
		##############################################################################

Uh oh!

Conversation

AaronHForgeFlow commented Jul 31, 2017

Use product supplier info also for customers

Uh oh!

MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Jun 28, 2018

Uh oh!

MiquelRForgeFlow commented Jun 28, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MiquelRForgeFlow Jun 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MiquelRForgeFlow commented Jul 2, 2018

Uh oh!

elicoidal left a comment

Choose a reason for hiding this comment

Uh oh!

elicoidal Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MiquelRForgeFlow commented Jul 3, 2018

Uh oh!

rafaelbn commented Sep 4, 2019

Uh oh!

AaronHForgeFlow commented Sep 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

MiquelRForgeFlow Jun 29, 2018 •

edited

Loading

elicoidal Jul 3, 2018 •

edited

Loading