Skip to content

[17.0][OU-ADD] product_pricelist_supplierinfo: Migration scripts #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedrobaeza wants to merge 1 commit into
base: 17.0
Choose a base branch
from
+12 −0
Open

[17.0][OU-ADD] product_pricelist_supplierinfo: Migration scripts #2212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions product_pricelist_supplierinfo/migrations/17.0.2.0.0/post-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Copyright 2026 Tecnativa - Pedro M. Baeza
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl-3.0)
from openupgradelib import openupgrade


@openupgrade.migrate()
def migrate(env, version):
openupgrade.logged_query(
env.cr,
"UPDATE product_pricelist_item SET no_supplierinfo_discount=True",
)
env["ir.default"].set("product.pricelist.item", "no_supplierinfo_discount", "true")
Copy link

@luisg123v luisg123v Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this?

I think this could be a source of functional discrepancies, new lines will start having this default but only in migrated databases that went through this migration script. What do you think about setting as default at field declaration instead?

Copy link
Member Author

@pedrobaeza pedrobaeza Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm sure, as this is only for migrated DBs. Users of these DBs are used to create pricelist items without having to mark any check for having that behavior, and if this default is not put, they will have differences between the old and new pricelist items. If they are aware, they will ask for removing it, or they will uncheck it when needed.

Copy link
Member Author

@pedrobaeza pedrobaeza Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If changing this default now, current users of 17 will have a change of behavior comparable to the migrated users.