[FIX] product_code_unique - remove duplicate warning for "Internal Reference"#2184
Open
anthonissen-a wants to merge 1 commit intoOCA:18.0from
Open
[FIX] product_code_unique - remove duplicate warning for "Internal Reference"#2184anthonissen-a wants to merge 1 commit intoOCA:18.0from
anthonissen-a wants to merge 1 commit intoOCA:18.0from
Conversation
rvalyi
reviewed
Jan 12, 2026
Member
rvalyi
left a comment
rvalyi
left a comment
There was a problem hiding this comment.
doing it this way feels a bit dangerous as it bypasses the method chain entirely. Imagine some module is doing something important in _onchange_default_code, it may not be called anymore because super is not called...
What about calling super and removing the "warning" key from the super result instead?
| ] | ||
|
|
||
| @api.onchange() | ||
| def _onchange_default_code(self): |
Contributor
There was a problem hiding this comment.
You cannot do that as you are not aware of other modules overriding this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the standard warnings from Odoo when trying to save a duplicate "Internal Reference", because this module already introduces a constraint avoiding duplicates.