[18.0] [MIG] pos_product_cost_security

[parvezqureshi]

No description provided.

[cvinh]

I tested it in runboat and I have no products in the pos screen with admin account (not belonging to any product_cost group)

[parvezqureshi]

not belonging to

Without this module, we got permission errors.
This is a glue module to avoid permission errors when loading data in the Point of Sale if the user has no standard_price (cost) field permissions.

For showing product, you want to add product_cost group.

[cvinh]

I'm sorry, I didn't know this module before, is it supposed to hide all products from a pos session and just hide error ... and only let people that have the right to see product cost to sell a product ? This is weird so I don't think so...
I know a guy who knows the answer... @pedrobaeza
#556

[pedrobaeza]

/ocabot migration pos_product_cost_security

This bridge module allows to bypass the problem, as the way things are loaded in PoS and the groups ORM handling in fields is a bit "tricky".

[cvinh]

/ocabot migration pos_product_cost_security

This bridge module allows to bypass the problem, as the way things are loaded in PoS and the groups ORM handling in fields is a bit "tricky".

Oh I see, then I understand better how pos_product_cost_security works. This is a sum up

• in v16 : without pos_product_cost_security the point of sale does not open at all with access right error. If we install the module, the point of sale opens and the seller can use it even if he has no cost access rights...
• in this PR : with or without the pos_product_cost_security, the point of sale opens but there are no products. if we search a product with "Search More" button, we have the access right error.

The expected behavior is that a user without the cost rights can use the point of sale

@parvezqureshi I think the PR from which you started does not work neither

[cvinh]

tested in runboat

[cvinh]

I added a fix to hide margin and cost fields in the backend https://github.com/parvezqureshi/product-attribute/pull/1/commits ... unless it's a core odoo's bug
@pedrobaeza we can open an issue at Odoo and wait... or merge this commit here... WDYT ?
@parvezqureshi please don't merge my PR before Pedro's answer

[pedrobaeza]

The patch seems correct.

[cvinh]

There is an issue with my patch parvezqureshi#1 (comment)
The pos session fails to load... access denied on cost field

[cvinh]

I'm wondering how this module will work with OCA/pos#1483
@Tisho99 do you have the use case where some employees are not allowed to see costs ?

[Tisho99]

Hello @cvinh,

I don’t have that specific use case. I’ve been testing OCA/pos#1483 using a POS user with minimum permissions, and I haven’t been able to reproduce the issue.

I assume this might be because I don’t have the product_cost_security module installed in my database.

In any case, both modules are available in version 17, and I don't think any problems have ever been found with them.