[19.0][MIG] product_dimension: Migration to 19.0. by hieulucky111 · Pull Request #2089 · OCA/product-attribute

hieulucky111 · 2025-10-01T09:50:14Z

No description provided.

osv -> orm test computation of volume in same UOM add test with conversion from cm refactor, new API, generic UOM computation fix wording in readme do not use camelcase for Models put dimensions in their own group Otherwise they are shown as weights. fill in placeholders in README README is actually rst, not md use a new-api onchange, update tests, refactor Also, spell "height" correctly.

…also with other languages than english

…ct_supplierinfo_tree_price_info

REF remove executable permission ADD missing tag images Conflicts: product_dimension/__openerp__.py

FIX remove oldname in field height ADD onchange calculate volume on product template

[MIG] Make modules uninstallable [MIG] Rename manifest files

… due to rounding issues (OCA#284)2

…o 11.0

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-12.0/product-attribute-12.0-product_dimension Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_dimension/

Currently translated at 100.0% (8 of 8 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_dimension Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_dimension/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-12.0/product-attribute-12.0-product_dimension Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_dimension/

Currently translated at 100.0% (11 of 11 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_dimension Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_dimension/pt/

Currently translated at 100.0% (11 of 11 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_dimension Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_dimension/de/

Currently translated at 100.0% (11 of 11 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_dimension Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_dimension/fr/

pedrobaeza · 2025-10-02T06:21:55Z

/ocabot migration product_dimension

rousseldenis · 2025-10-06T09:43:29Z

/ocabot migration product_dimension

ferran-S73 · 2025-10-16T07:09:42Z

product_dimension/models/product_product.py

+        "uom.uom",
+        "Dimensional UoM",
+        help="UoM for length, height, width",
+        default=lambda self: self.env.ref("uom.product_uom_meter"),


@hieulucky111 I think this default isn't working as intended since it's overriding the unit I choose when creating a product manually. I'm unsure if this is the case for previous versions though.

Also, this is more of a personal doubt. Since UoM categories no longer exist in v19 should we try and filter the available uoms for this field somehow? Odoo's approach in some settings fields is just to hardcode a couple of UoM for each category though I don't quite like it.
https://github.com/odoo/odoo/blob/9900375bc0bac2754150fd8cd6a1e45ecad8da83/addons/product/models/res_config_settings.py#L14

Hello @ferran-S73
I’ve rechecked the behavior in both versions 18 and 19. When creating a new Product Template and selecting a Dimension UoM, the selected UoM disappears after saving. (Same issue in both versions)

Regarding the UoM filter, we could use a System Parameter to store the list of available UoM names. However, I don’t think that’s necessary for now.

It's likely that this issue can be solved by aligning with how Odoo does this for weight, by storing the UoM on the product template (https://github.com/odoo/odoo/blob/27b3d2fc055c586f4d53c92f5a7a93301d7d7d17/addons/product/models/product_template.py#L110-L113).

hello @StefanRijnhart, do you see this as a critical blocker, or can we treat it as a future enhancement?
Personally, I think we can address this in a later.

I'd say it's pretty serious if this module provides a field that is not stored when creating a new record even if the user has selected a value for it. The product.template model is now more prominent than back when this (old) module was first introduced, so the impact of the bug has gotten bigger even if the bug has existed in past versions.

Ok, i will improve this soon.

hello @StefanRijnhart, i have applied your suggestion. I also move the default UoM from product.product to product.template. (Because variant creation will set again the value of product template).
Thank you.

Thanks for the update! Checking runboat, I still seem to be able to reproduce the original issue. Did it work for you while testing locally?

Yes, it works for me before pushing the updated code. Maybe we need to upgrade again module?

Weird. The failure to store the dimensional uom when creating product templates is easily reproced in a test, it turns out. The solution is also easy: apparently, a similar issue occurs with the other fields in this module, and this is fixed with the override on _prepare_variant_values. Fix proposed onto your branch in komit-consulting#1. You can squash it into your own commit.

Vang-NguyenPhu

LGTM

Reyes4711-S73

LGTM

Reyes4711-S73 · 2025-11-06T06:57:24Z

@OCA/product-maintainers Please, can you merge this PR?

OCA-git-bot · 2025-11-06T07:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

mav-adhoc · 2025-12-17T15:55:49Z

LGTM

BhaveshHeliconia

LGTM!

JordiMForgeFlow · 2026-01-16T07:46:18Z

@rousseldenis could you merge this one? :)

StefanRijnhart · 2026-01-16T07:53:46Z

Is there no interest in fixing #2089 (review)?

Camille0907

Migration LGTM, thank you 🙂

Camille0907 · 2026-01-19T15:42:15Z

@OCA/product-maintainers Hello, is there anything missing, before we can get the PR merged ? 🙂

JordiMForgeFlow · 2026-02-13T12:27:18Z

@rousseldenis could this one be merged?

StefanRijnhart · 2026-02-15T10:48:51Z

@JordiMForgeFlow Let's wait until #2089 (review) is fixed. We found the solution now.

lepistone and others added 30 commits October 1, 2025 16:21

Add missing default oca icons

573ea91

[UPD] prefix versions with 8.0

24a2c47

[MIG] Make modules uninstallable

128afc0

[FIX] product_dimension: Now domain on dimensional_uom_id is working …

80725dd

…also with other languages than english

[FIX] flake 8 error on modules product_dimension, product_gtin, produ…

0988ff0

…ct_supplierinfo_tree_price_info

ADD test case with product template

90a02c4

REF remove executable permission ADD missing tag images Conflicts: product_dimension/__openerp__.py

[ADD] Dimensions fields in product.template

00862d8

FIX remove oldname in field height ADD onchange calculate volume on product template

Module structure, views & license headers

ba3ab5f

[MIG] Make modules uninstallable [MIG] Rename manifest files

[MIG] product_dimension: Migration to 11.0

933ade2

[9.0][product_dimension][FIX] Fix volume being incorrectly calculated…

11cdcc2

… due to rounding issues (OCA#284)2

[MIG]: Adding suggested changes

07b63a5

[MIG] product_dimension: Adding missing po files and improvemnets

11e64da

[MIG] product_dimension: Adding lambda to domain function, Update readme

6696ace

[IMP] product_dimension: Code cleanup/improvements during migration t…

98190b3

…o 11.0

[IMP] product_dimension: Reset volume when parameters not valid

db82a33

[MIG] product_dimension: Migration to 12.0

8dbfdee

[IMP] product_dimension: Works with many variants and split Readme

ad6fc1b

[FIX] rename length to product_length

373f33d

[UPD] README.rst

7e1f0a3

Added translation using Weblate (Portuguese)

ad0c8c0

[IMP] product_dimension: black, isort, prettier

42a0dbf

[MIG] product_dimension: Migration To 13.0

af65e76

[UPD] README.rst

30344de

rousseldenis added needs review migration labels Oct 6, 2025

OCA-git-bot added this to the 19.0 milestone Oct 6, 2025

OCA-git-bot mentioned this pull request Oct 6, 2025

Migration to version 19.0 #2075

Open

72 tasks

ferran-S73 reviewed Oct 16, 2025

View reviewed changes

Vang-NguyenPhu approved these changes Oct 17, 2025

View reviewed changes

eugenios73 mentioned this pull request Oct 24, 2025

[19.0][MIG] product_logistics_uom: Migration from 18.0 to 19.0 #2113

Open

Reyes4711-S73 approved these changes Nov 6, 2025

View reviewed changes

OCA-git-bot added the approved label Nov 6, 2025

OCA-git-bot added the ready to merge label Nov 6, 2025

ferran-S73 approved these changes Nov 6, 2025

View reviewed changes

BhaveshHeliconia approved these changes Jan 7, 2026

View reviewed changes

Camille0907 approved these changes Jan 19, 2026

View reviewed changes

This was referenced Jan 20, 2026

[MIG] delivery_carrier_picking_valid: Migration to 19.0 OCA/delivery-carrier#1102

Open

[MIG] delivery_carrier_picking_valid_dangerous_goods: Migration to 19.0 OCA/delivery-carrier#1103

Open

hieulucky111 force-pushed the 19.0-mig-product_dimension branch from 8b8b9bb to ce7c56b Compare January 30, 2026 09:49

[MIG] product_dimension: Migration to 19.0

2ff7c80

hieulucky111 force-pushed the 19.0-mig-product_dimension branch from ce7c56b to 2ff7c80 Compare January 30, 2026 09:54

Jortolsa-S73 approved these changes Feb 8, 2026

View reviewed changes

gediminasvenc added a commit to linserv/product-attribute that referenced this pull request Feb 20, 2026

[MIG] product_dimension: from PR OCA#2089

03ad4fe

Uh oh!

Comments

Conversation

hieulucky111 commented Oct 1, 2025

Uh oh!

pedrobaeza commented Oct 2, 2025

Uh oh!

rousseldenis commented Oct 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vang-NguyenPhu left a comment

Choose a reason for hiding this comment

Uh oh!

Reyes4711-S73 left a comment

Choose a reason for hiding this comment

Uh oh!

Reyes4711-S73 commented Nov 6, 2025

Uh oh!

OCA-git-bot commented Nov 6, 2025

Uh oh!

mav-adhoc commented Dec 17, 2025

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

JordiMForgeFlow commented Jan 16, 2026

Uh oh!

StefanRijnhart commented Jan 16, 2026

Uh oh!

Camille0907 left a comment

Choose a reason for hiding this comment

Uh oh!

Camille0907 commented Jan 19, 2026

Uh oh!

JordiMForgeFlow commented Feb 13, 2026

Uh oh!

StefanRijnhart commented Feb 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants