[17.0][MIG] product_abc_classification: Migration to 17.0 by fgaviiria · Pull Request #1686 · OCA/product-attribute

fgaviiria · 2024-07-16T22:31:23Z

No description provided.

rousseldenis · 2024-07-19T06:20:38Z

/ocabot migration product_abc_classification

rousseldenis

Code review

gbrito · 2024-08-15T22:07:58Z

product_abc_classification/models/abc_classification_product_level.py

+                    )
+                )
+
+    @api.onchange("product_tmpl_id")


It would be nice to convert this onchange to a computed field on the product_id.

github-actions · 2025-03-23T12:19:38Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

rvalyi · 2025-03-23T17:32:15Z

/ocabot merge nobump

OCA-git-bot · 2025-03-23T17:32:22Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1686-by-rvalyi-bump-nobump, awaiting test results.

Signed-off-by rvalyi

OCA-git-bot · 2025-03-23T17:38:27Z

@rvalyi The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name product-attribute --branch 17.0 --addons-dir /tmp/tmpknocilbd --commit failed with output:

Both .md and .rst found for DESCRIPTION. Please remove one of /tmp/tmpknocilbd/product_abc_classification/readme/DESCRIPTION.rst or /tmp/tmpknocilbd/product_abc_classification/readme/DESCRIPTION.md.

Merge is failing

rvalyi

@fgaviiria please remove the old .rst documentation files (see error message above). You can do this with by amending the penultimate commit with:
git rebase HEAD~3 -i
Choose to amend (e) the penultimate commit.
And then commit the old .rst files with the --amend option
Finish the rebase with gir rebase --continue
Push with the --force option.

anothingguy · 2025-07-07T08:41:47Z

noticed this migration removed feature: setting profile on product category

rousseldenis · 2025-09-02T15:10:57Z

/ocabot rebase

…n logic pluggable

…tests

Currently translated at 8.0% (6 of 75 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_abc_classification Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_abc_classification/es/

Currently translated at 100.0% (75 of 75 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_abc_classification Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_abc_classification/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_abc_classification Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_abc_classification/

Currently translated at 100.0% (74 of 74 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_abc_classification Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_abc_classification/it/

The test on unicity constraint is passing but the error log from the ORM must be muted to not get a false negative.

OCA-git-bot · 2025-09-02T15:11:07Z

Congratulations, PR rebased to 17.0.

rousseldenis

Ooops, @fgaviiria could you remove *.rst files ?

github-actions · 2026-02-01T12:30:08Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

fgaviiria force-pushed the 17.0-mig-product_abc_classification branch 5 times, most recently from 0bf3ec5 to d8e3c8b Compare July 18, 2024 00:43

fgaviiria mentioned this pull request Jul 18, 2024

Migration to version 17.0 #1446

Open

69 tasks

jeer2234 approved these changes Jul 18, 2024

View reviewed changes

rousseldenis added needs review migration labels Jul 19, 2024

OCA-git-bot added this to the 17.0 milestone Jul 19, 2024

rousseldenis approved these changes Jul 19, 2024

View reviewed changes

OCA-git-bot added the approved label Jul 19, 2024

gbrito suggested changes Aug 15, 2024

View reviewed changes

OCA-git-bot removed the approved label Aug 15, 2024

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 23, 2025

rvalyi previously approved these changes Mar 23, 2025

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Mar 23, 2025

Merge PR #1686 into 17.0

82cb6c7

Signed-off-by rvalyi

OCA-git-bot added the bot is merging ⏳ label Mar 23, 2025

OCA-git-bot removed the bot is merging ⏳ label Mar 23, 2025

rvalyi requested changes Mar 23, 2025

View reviewed changes

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 30, 2025

anothingguy mentioned this pull request Jun 27, 2025

[17.0][MIG] product_abc_classification: Migration to 17.0 #2007

Open

MiquelRForgeFlow and others added 24 commits September 2, 2025 15:11

[ADD] product_abc_classification

6f6bbb6

[IMP] product_abc_classification: Makes the classification computatio…

6c6308e

…n logic pluggable

[IMP] product_abc_classification/base: Restore module name

bbb2e75

[IMP] product_abc_classification: add product smart button in profile

53de6a9

[FIX] product_abc_classification: Remove not working context attributes

cfbe029

[FIX] product_abc_classification: Use the good _for_xml_id() and add …

0ace8f1

…tests

[FIX] product_abc_classification: Adapt write() for a multi recordset

7db6e7b

[IMP] product_abc_classification: Improve profile view + help

03855c3

[FIX] product_abc_classification: Translated terms into views

d975758

[FIX] product_abc_classification: Fix tests

b9a8c2b

[UPD] Update product_abc_classification.pot

9586873

oca-github-bot post-merge updates

8cf2cce

Added translation using Weblate (Spanish)

3f27b74

[UPD] Update product_abc_classification.pot

3ed7545

Added translation using Weblate (Italian)

6c8991d

product_abc_classification: fix invalidate cache warning

321639b

product_abc_classification: fix tests error log

a588a58

The test on unicity constraint is passing but the error log from the ORM must be muted to not get a false negative.

[BOT] post-merge updates

7595ae4

[IMP] product_abc_classification: pre-commit auto fixes

633d759

[MIG] product_abc_classification: Migration to 17.0

e38fad2

OCA-git-bot force-pushed the 17.0-mig-product_abc_classification branch from d8e3c8b to e38fad2 Compare September 2, 2025 15:11

rousseldenis approved these changes Sep 30, 2025

View reviewed changes

rousseldenis requested changes Sep 30, 2025

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 1, 2026

Uh oh!

Comments

Conversation

fgaviiria commented Jul 16, 2024

Uh oh!

rousseldenis commented Jul 19, 2024

Uh oh!

rousseldenis left a comment

Choose a reason for hiding this comment

Uh oh!

gbrito Aug 15, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 23, 2025

Uh oh!

rvalyi commented Mar 23, 2025

Uh oh!

OCA-git-bot commented Mar 23, 2025

Uh oh!

OCA-git-bot commented Mar 23, 2025

Uh oh!

rvalyi left a comment

Choose a reason for hiding this comment

Uh oh!

anothingguy commented Jul 7, 2025

Uh oh!

rousseldenis commented Sep 2, 2025

Uh oh!

OCA-git-bot commented Sep 2, 2025

Uh oh!

rousseldenis left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants