Conversation
59c8a32 to
ebd25a3
Compare
Dummy PR to test the following check: - OCA/odoo-pre-commit-hooks#175
Dummy PR to test the following check: - OCA/odoo-pre-commit-hooks#175
Dummy PR to test the following check: - OCA/odoo-pre-commit-hooks#175
Dummy PR to test the following check: - OCA/odoo-pre-commit-hooks#175
|
Please, review The name of the check, the message Notice the dummy PR: |
a3fae7d to
6d85807
Compare
… is too long Check if the weblate component name which is formed by: - Repo Name - Odoo version - Module name If it exceeds a certain length (90 characters) register an error indicating that the module name is too long.
…over all the tests together insteaad of individual
6d85807 to
0cf591a
Compare
hparfr
left a comment
There was a problem hiding this comment.
Thanks.
The error message is clear. 👍
|
Thanks @moylop260 ! If you compute the full length like that you can set the limit to 100 instead of 90. |
|
Hi @sbidoul I agree with your reasoning regarding the limit. However, I just wanted to share a couple of thoughts before: Module PortabilitySometimes we move modules between projects. Custom BranchesWhile rare, some custom repositories (not OCA) might use branch names like I agree that your initial value of 90 having a small margin for error might be safer than fitting it to the exact character count. What do you think? If you still prefer the stricter limit, let me know and I'll open the PR to adjust it, no problem! |
Check if the weblate component name
(which is formed by Repo Name + Odoo version + Module name) exceeds a certain length (90 characters).
If it does, register an error indicating that the module name is too long.
Related to
Raised from:
Where
stock-logistics-release-channel-18.0-sale_stock_release_channel_delivery_date_plan_shipment_lead_timeis 101 size