[17.0][ADD] mis_builder_contract: New module#57
Open
juancarlosonate-tecnativa wants to merge 1 commit intoOCA:17.0from
Open
[17.0][ADD] mis_builder_contract: New module#57juancarlosonate-tecnativa wants to merge 1 commit intoOCA:17.0from
juancarlosonate-tecnativa wants to merge 1 commit intoOCA:17.0from
Conversation
juancarlosonate-tecnativa
force-pushed
the
17.0-add-mis_builder_contract
branch
from
40ed485 to
aa9be35
Compare
pedrobaeza
requested changes
May 21, 2025
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
I have tried and I'm not able to make it work on runboat. Maybe you should include a demo mis report and template with the proper definitions for a direct test.
juancarlosonate-tecnativa
force-pushed
the
17.0-add-mis_builder_contract
branch
from
aa9be35 to
4ed0408
Compare
Author
|
@pedrobaeza Added simple demo data for testing and fixed the default account issue, ready to review. |
Author
|
@sbidoul Could you take a look when you have a moment, please? Thanks! |
pedrobaeza
approved these changes
Jun 26, 2025
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
It seems to work properly and quick code review
juancarlosonate-tecnativa
force-pushed
the
17.0-add-mis_builder_contract
branch
from
4ed0408 to
308a54f
Compare
Member
|
pre-commit is failing. |
juancarlosonate-tecnativa
force-pushed
the
17.0-add-mis_builder_contract
branch
from
308a54f to
b8f5fbc
Compare
TT56279
juancarlosonate-tecnativa
force-pushed
the
17.0-add-mis_builder_contract
branch
from
b8f5fbc to
ae512ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module adds a new model for Actuals(alternative) MIS data sources based on the calculation of virtual lines generated according to the contract line dates, amounts, and recurrence intervals, for both customers and vendors.
@Tecnativa TT56279
@pedrobaeza