Skip to content

[17.0][MIG] mis_builder_budget_product: Migration to 17.0#53

Open
BurkhalterY wants to merge 12 commits intoOCA:17.0from
Burkhalter-IT:17.0-mig-mis_builder_budget_product
Open

[17.0][MIG] mis_builder_budget_product: Migration to 17.0#53
BurkhalterY wants to merge 12 commits intoOCA:17.0from
Burkhalter-IT:17.0-mig-mis_builder_budget_product

Conversation

@BurkhalterY
Copy link
Member

No description provided.

@BurkhalterY BurkhalterY marked this pull request as ready for review October 23, 2024 06:51
@BurkhalterY BurkhalterY mentioned this pull request Oct 23, 2024
2 tasks
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 23, 2025
@BurkhalterY
Copy link
Member Author

Hi @dzungtran89,
Maybe could you review it please? There is no maintainer on this module and you did the last migration.
Thank you!

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 2, 2025
/>
<field name="arch" type="xml">
<field name="balance" position="after">
<field name="company_id" invisible="1" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="company_id" invisible="1" />
<field name="company_id" column_invisible="1" />

Ref

@dzungtran89
Copy link

Hi @BurkhalterY , thank you.

There is one suggested change, lgtm overall.

@BurkhalterY BurkhalterY force-pushed the 17.0-mig-mis_builder_budget_product branch from 74d083e to 3f55577 Compare April 22, 2025 07:09
@BurkhalterY
Copy link
Member Author

Hi @dzungtran89,
Thank you for your feedback, I committed the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants