-
-
Notifications
You must be signed in to change notification settings - Fork 177
[17.0][ADD] product_margin_report_sale_margin #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
[17.0][ADD] product_margin_report_sale_margin #246
Conversation
…gin in the Product Margins report [IMP] product_margin_report_sale_margin: Add tests
0500fb1 to
64a5592
Compare
christian-ramos-tecnativa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I’d like to add more context to these two new fields. Currently, this report includes all sales and purchases in the range by default when calculating the values.
For example, if I’ve purchased 100 tables but only 10 have been sold so far, the margin will appear negative, which can be misleading. In this case, the report seems to reflect more of a cost vs. revenue view of the product rather than actual profitability.
Here’s a screenshot to illustrate the scenario:

This new values add a lot of value to this report.
Thanks
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
rrebollo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.
adasatorres
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM!
|
ping @legalsylvain |
@BinhexTeam
This new module allows you to add two new fields for the sales margin in the Product Margins report.