Open
Conversation
92c6577 to
bc4a8c6
Compare
Jaimermaccione
approved these changes
Feb 20, 2026
Jaimermaccione
left a comment
There was a problem hiding this comment.
@Tisho99 Functionally reviewed in a local environment.
Additional validations were performed beyond the basic flow:
-
BoM change on existing MO
Changing the Bill of Materials on an existing Manufacturing Order correctly triggers the warning. -
Manufacturing Order states
State-related checks are not applicable:- Cancelled Manufacturing Orders cannot be reverted.
- Done Manufacturing Orders only allow dismantling, which does not return them to a previous state.
-
BoM warning update
Updating the warning message on the BoM is correctly reflected in already created Manufacturing Orders. -
Multiple BoMs
For products with multiple Bills of Materials, the warning shown always corresponds to the selected BoM.
With all these checks, the module behaves as expected and the README accurately describes the verified behavior.
LGTM!
bc4a8c6 to
4a73962
Compare
4a73962 to
4752b2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module allows to configure a warning on manufacturing orders when a bill of materials is selected
This module is similar as other OCA modules such as sale_order_warn_message
T-9321