Skip to content

[18.0][MIG] mrp_stock_move_actual_date: Migration to 18.0#1731

Open
AungKoKoLin1997 wants to merge 11 commits intoOCA:18.0from
qrtl:18.0-mig-mrp_stock_move_actual_date
Open

[18.0][MIG] mrp_stock_move_actual_date: Migration to 18.0#1731
AungKoKoLin1997 wants to merge 11 commits intoOCA:18.0from
qrtl:18.0-mig-mrp_stock_move_actual_date

Conversation

@AungKoKoLin1997
Copy link
Contributor

@qrtl QT6430

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test. LGTM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add maintainers.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-mrp_stock_move_actual_date branch from 2cef876 to 7d935b0 Compare February 19, 2026 10:17
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-mrp_stock_move_actual_date branch from 7d935b0 to 387d5fe Compare February 20, 2026 01:06
Copy link

@nobuQuartile nobuQuartile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: LGTM
minor code improvement points

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-mrp_stock_move_actual_date branch from 387d5fe to 750c25e Compare February 20, 2026 02:19
Copy link

@nobuQuartile nobuQuartile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: LGTM

@@ -0,0 +1,2 @@
This module adopts the functionality of stock_move_actual_date to
manufacturing orders, unbuild orders, and scraps.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish this description could be improved.
If I'm not familiar with stock_move_actual_date I won't be able to tell what this does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt I improved the description a little bit.
Could you please review?

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-mrp_stock_move_actual_date branch from 7029e3e to 0474e63 Compare February 24, 2026 09:53
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants