[18.0][REM] quality_control_oca: remove unused object_id on qt_test#1716
Open
remi-filament wants to merge 1 commit intoOCA:18.0from
Open
[18.0][REM] quality_control_oca: remove unused object_id on qt_test#1716remi-filament wants to merge 1 commit intoOCA:18.0from
remi-filament wants to merge 1 commit intoOCA:18.0from
Conversation
remi-filament
force-pushed
the
18.0-imp-quality_control_oca
branch
from
0c7ee6a to
96d999e
Compare
diggy128
approved these changes
Feb 22, 2026
Contributor
diggy128
left a comment
diggy128
left a comment
There was a problem hiding this comment.
LGTM!
I think this field was left over from the original NaN module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of #1568 from 17.0 to 18.0
As reported in issue #1378 qc_test type field allows for display of object_id for which is selection is set(), creating invalid display.
Since this field does not seem to be used anywhere (none of the depending modules are using it neither), I propose with this PR to remove both object_id and type from qc_test.
Note : a field with same name object_id is used on qc_inspection model and make a lot of sense there !