[18.0][MIG] mail_template_conditional_attachment: Migration to 18.0 #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Nice, originally a port of OCA/social#521 I think. Can you squash the clean up commits a little bit and make sure the module name is present in all of the commit messages?
mail_template_conditional_attachment/i18n/mail_template_conditional_attachment.pot
Outdated
Show resolved
Hide resolved
P-H-Phuc
force-pushed
the
18.0-mig-mail_template_conditional_attachment
branch
2 times, most recently
from
435c3cc to
c4309d6
Compare
[IMP] Readmes [ADD] icon.png Remove OCA icons [ADD] icon.png
P-H-Phuc
force-pushed
the
18.0-mig-mail_template_conditional_attachment
branch
3 times, most recently
from
6b82476 to
fcaf162
Compare
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks for the updates! Looking good now, only one remaining suggestion.
mail_template_conditional_attachment/security/mail_template_condition_attachment_security.xml
Outdated
Show resolved
Hide resolved
P-H-Phuc
force-pushed
the
18.0-mig-mail_template_conditional_attachment
branch
from
fcaf162 to
036a40c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module was initially part of the Foodcoop set of addons. We're now migrating it to 18.0 and taking this occasion to contribute it to OCA.