-
-
Notifications
You must be signed in to change notification settings - Fork 104
[19.0][MIG] mail_activity_board: Migration to 19.0 #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
[19.0][MIG] mail_activity_board: Migration to 19.0 #87
Conversation
…d in boards. (#283) * [ADD] Module that insert activities board. * [FIX] Author error in __manifest__ file and style changes. * [FIX] Fix replace in view, rename files and style changes. * [FIX] Enumerated list ends without a blank line; unexpected unindent. * [FIX] Name fail. * [FIX] Bug in view. * [FIX] Add button Activities in mail.thread and readme folder. Others improvements in style of code. * [FIX] Type 'tree' not found in registry: problem solved. * [FIX] Dependence change: 'mail' for 'calendar'. * [FIX] Eliminated unnecessary imports. * [FIX] Bugs about js and if/else. * [FIX] Improvements following guide lines and eliminating unnecessary attributes in views. * [ADD] Added counter in the 'Activities List' button. * [FIX] Bugs in javascript with 'Activities' button. * [ADD] Tests folder. * [FIX] Deleted references to modules not installed. * [FIX] Formatting javascript. * [FIX] Bug: added a soft line before a class. * [FIX] Bug: OCA/social#283 (comment) * [FIX] Escaping 'lt' in xml file. Bug: OCA/social#283 (comment) * [FIX] The meeting attendees are shown in kanban mode on the meeting board. * [FIX] Hide in form view of the activity board the assistant field if the activity is not a meeting type or if there are no assistants. * [FIX] Change to default kanban view for partners.
[FIX] add title to <i> tag and removed console.log in js Co-authored-by: Miquel Raïch <miquel.raich@forgeflow.com> Co-authored-by: Miquel Raïch <miquel.raich@forgeflow.com>
Add a direct access from activity calendar and form views to the linked model instance. Bedore this change, it was not possible to access to the model instance linked to an activity from the calendar view nor from the view opened by clicling on the activity into the calendar [IMP] mail_activiy_board: Restrict related_model_instance selection to models supporting mail acitvities Co-Authored-By: Miquel Raïch <miquel.raich@eficent.com>
users when accessing records that inherit mail.activity mixing
…s only visible if the user has the permission. TT43037
Currently translated at 95.4% (21 of 22 strings) Translation: social-16.0/social-16.0-mail_activity_board Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_board/fr/
`image_small` field has been renamed to `image_small` since the use of `image.mixin`
Currently translated at 100.0% (22 of 22 strings) Translation: social-17.0/social-17.0-mail_activity_board Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_activity_board/it/
…and using the open_origin function instead.
…ds anymore The regular relational model fetches records using web_search_read (https://github.com/odoo/odoo/blob/7c640426903bc6fa4c972406df1f0905557cf7e5/addons/web/static/src/model/relational_model/relational_model.js#L582). This method formats reference fields as { id: { id: 27, model: "res.partner"}, display_name: "Azure Interior, Brandon Freeman"} (https://github.com/odoo/odoo/blob/7c640426903bc6fa4c972406df1f0905557cf7e5/addons/web/models/models.py#L220-L224) This structure is used when rendering the relational model widget (https://github.com/odoo/odoo/blob/7c640426903bc6fa4c972406df1f0905557cf7e5/addons/web/static/src/model/relational_model/utils.js#L467-L475). However, the calendar web model fetches records using search_read (https://github.com/odoo/odoo/blob/7c640426903bc6fa4c972406df1f0905557cf7e5/addons/web/static/src/views/calendar/calendar_model.js#L489). This returns values for reference fields in the conventional format "res.partner,27", but they are still rendered by the same widget when the calendar popup view is opened, resulting in an error 'TypeError: value.id is undefined'.
Co-authored-by: Stefan Rijnhart <stefan@opener.amsterdam>
CRogos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you have a look on these improvements. This module is a little messy :(
#120
atchuthan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review 👍
CRogos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should wait for / add this PR: #120
CRogos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#120 has been merged. Please add to migration.
No description provided.