Skip to content

[18.0][MIG] mail_template_substitute: Migration to 18.0 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
youelEl wants to merge 2 commits into from
Closed

[18.0][MIG] mail_template_substitute: Migration to 18.0 #39

youelEl wants to merge 2 commits into from

Conversation

@youelEl
Copy link

@youelEl youelEl commented Feb 27, 2025

No description provided.

@youelEl youelEl mentioned this pull request Feb 27, 2025
Closed
@pedrobaeza pedrobaeza changed the title 18.0 mig mail template substitute [18.0][MIG] mail_template_substitute: Migration to 18.0 Feb 27, 2025
@pedrobaeza
Copy link
Member

pedrobaeza commented Feb 27, 2025

Thanks for the the PR.

I have modified the PR title to match the expected one. You have to do the git fetch command crossing both repositories, for not losing the commit history.

mpascuall
mpascuall approved these changes Mar 14, 2025
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the git fetch to have all the commits and it LGTM, tested in runboat

peluko00
peluko00 approved these changes Mar 14, 2025
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when fetch commits

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Mar 14, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@atchuthan atchuthan mentioned this pull request May 23, 2025
Closed
@marielejeune
Copy link
Contributor

marielejeune commented May 23, 2025

Hi @youelEl , do you plan to finish this PR? Thanks

@blopa98-S73
Copy link

blopa98-S73 commented Aug 6, 2025

Hi @youelEl , reviewing this PR, would it make sense to apply the same functionality to the account.move.send model? I think it's interesting.

cc: @pedrobaeza

@baimont
Copy link
Contributor

baimont commented Sep 15, 2025

hi @youelEl

are you at the oca days? do you plan to finish this pr? thanks

@eugenios73 eugenios73 mentioned this pull request Oct 21, 2025
Open
@eugenios73
Copy link

eugenios73 commented Oct 21, 2025

@pedrobaeza I have been replace this PR by #98 please close this PR

FYI @mpascuall @peluko00 @kiferrara @atchuthan @baimont @blopa98-S73

@pedrobaeza pedrobaeza closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@atchuthan atchuthan atchuthan approved these changes

@peluko00 peluko00 peluko00 approved these changes

@kiferrara kiferrara kiferrara approved these changes

@mpascuall mpascuall mpascuall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.