[18.0][FIX] mail_message_search : prevent db crash

[AungKoKoLin1997]

Supersedes #72

@qrtl QT5088

[OCA-git-bot]

Hi @yostashiro, @AungKoKoLin1997,
some modules you are maintaining are being modified, check this out!

[nobuQuartile]

Functional review

[flotho]

Hi
Thanks for the PR.
I get the point.
Yet I'm wondering why you didn't defined a default value as a system parameter.
For sure one can argue that "BIG" database depends on so many factor as the server size, setup, etc... yet if you're pointing 5000 in you exemple maybe you've experienced such kind of limitation.
hat is you PoV on this?

Regards

[AungKoKoLin1997]

Yet I'm wondering why you didn't defined a default value as a system parameter.
For sure one can argue that "BIG" database depends on so many factor as the server size, setup, etc... yet if you're pointing 5000 in you exemple maybe you've experienced such kind of limitation.

@flotho
I’m not sure I fully understand your point.
My preference was to avoid setting a default limit, because the module is intended to run without any limitation in most environments. The limitation is meant to be applied only for databases with a very large volume of data.
We’ve documented this in CONFIGURE.md: users can set the limit when they actually need it for their environment.

[flotho]

LGTM

[yostashiro]

I think it'd be good to have a default value as @flotho suggests, but I'm not against having no value either.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[etobella]

Makes sense

[etobella]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-125-by-etobella-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 718c636. Thanks a lot for contributing to OCA. ❤️