-
-
Notifications
You must be signed in to change notification settings - Fork 104
[19.0][MIG] mail_composer_cc_bcc #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
norlinhenrik
wants to merge
39
commits into
OCA:19.0
Choose a base branch
from
norlinhenrik:19.0-mig-mail_composer_cc_bcc
base: 19.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[19.0][MIG] mail_composer_cc_bcc #113
norlinhenrik
wants to merge
39
commits into
OCA:19.0
from
norlinhenrik:19.0-mig-mail_composer_cc_bcc
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents when no cc or bcc
Currently translated at 83.3% (15 of 18 strings) Translation: social-16.0/social-16.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_composer_cc_bcc/es/
Currently translated at 100.0% (18 of 18 strings) Translation: social-16.0/social-16.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_composer_cc_bcc/es/
Currently translated at 100.0% (18 of 18 strings) Translation: social-16.0/social-16.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_composer_cc_bcc/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_composer_cc_bcc/
Currently translated at 100.0% (17 of 17 strings) Translation: social-17.0/social-17.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_composer_cc_bcc/it/
…onstraint "unique_mail_message_id_res_partner_id_if_set" when adding the same user to CC field that is already set as a follower
### This changes 1. Refactor _generate_template_recipients 2. Fix invalid-email-address for Bcc - In standard, Bcc key in dict message was stripped in https://github.com/odoo/odoo/blob/4394940a09900aa5b42cbc05355880598608d1b6/odoo/addons/base/models/ir_mail_server.py#L676 - Duplicate the key to retain for later assertion
Default behavior in ´mail´ is that _prepare_outgoing_list() returns mails with email_to as a LIST. ´mail_tracking´ is dependent on this behvaior, and it converts LIST to STRING using COMMASPACE. Without the fix in this commit, the combination of ´mail_composer_cc_bcc´ and ´mail_tracking´ will produce email_to with comma between each character.
Currently translated at 100.0% (17 of 17 strings) Translation: mail-18.0/mail-18.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_composer_cc_bcc/it/
Contributor
|
@norlinhenrik Thanks for your PR but there is a existing migration PR for this module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.