-
-
Notifications
You must be signed in to change notification settings - Fork 104
[19.0][MIG] mail_outbound_static #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
CasVissers-360ERP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
4dcb46c to
f9aefc9
Compare
|
Actually there is an issue with the from e-mail address with this version. The name disappears in the from (it's only the e-mail address). |
f9aefc9 to
0c1ada4
Compare
|
@CasVissers-360ERP Thanks! Should be fixed now, could you check again? |
|
@astirpe all good now! Thanks! |
0c1ada4 to
d8b2412
Compare
StefanRijnhart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
This PR has the |
|
@CasVissers-360ERP @StefanRijnhart |
|
I can confirm that issue is fixed now. |
StefanRijnhart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! If the change would not apply to earlier version of Odoo it would be best to squash the commits.
* Allow for the configuration of the FROM header for outbound emails, and move the existing from header to Sender as per RFC-2822
Fixing and extending tests Add setup
Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>
use sudo to get ir.config_parameter, otherwise when normal users try to send email they get AccessError
Since 15.0, smtp info is prepared in _prepare_email_message() which is called from send_email(), and the smtp info manipulation should be done in this method instead of in send_email().
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-mail_outbound_static Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_outbound_static/
Currently translated at 100.0% (7 of 7 strings) Translation: social-17.0/social-17.0-mail_outbound_static Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_outbound_static/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: mail-18.0/mail-18.0-mail_outbound_static Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_outbound_static/
…ools instead of email.utils.
e51af53 to
2fd4bdd
Compare
|
Squashed and rebased, thanks! |
No description provided.