Skip to content

Conversation

@astirpe
Copy link
Member

@astirpe astirpe commented Nov 6, 2025

No description provided.

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@astirpe astirpe marked this pull request as ready for review November 6, 2025 15:05
@astirpe astirpe force-pushed the 19_mig_mail_outbound_static branch from 4dcb46c to f9aefc9 Compare November 6, 2025 15:19
@CasVissers-360ERP
Copy link

Actually there is an issue with the from e-mail address with this version. The name disappears in the from (it's only the e-mail address).

@astirpe astirpe force-pushed the 19_mig_mail_outbound_static branch from f9aefc9 to 0c1ada4 Compare November 6, 2025 19:19
@astirpe
Copy link
Member Author

astirpe commented Nov 6, 2025

@CasVissers-360ERP Thanks! Should be fixed now, could you check again?

@CasVissers-360ERP
Copy link

@astirpe all good now! Thanks!

@astirpe astirpe force-pushed the 19_mig_mail_outbound_static branch from 0c1ada4 to d8b2412 Compare November 20, 2025 15:36
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@astirpe
Copy link
Member Author

astirpe commented Nov 21, 2025

@CasVissers-360ERP @StefanRijnhart
I added a necessary change, fixing a bug discovered after using this module in production. I temporary kept it in a separate commit for easier review.

@CasVissers-360ERP
Copy link

I can confirm that issue is fixed now.

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! If the change would not apply to earlier version of Odoo it would be best to squash the commits.

OCA-git-bot and others added 27 commits November 21, 2025 15:04
Since 15.0, smtp info is prepared in _prepare_email_message() which is called
from send_email(), and the smtp info manipulation should be done in this method
instead of in send_email().
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-16.0/social-16.0-mail_outbound_static
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_outbound_static/
Currently translated at 100.0% (7 of 7 strings)

Translation: social-17.0/social-17.0-mail_outbound_static
Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_outbound_static/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: mail-18.0/mail-18.0-mail_outbound_static
Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_outbound_static/
@astirpe astirpe force-pushed the 19_mig_mail_outbound_static branch from e51af53 to 2fd4bdd Compare November 21, 2025 14:04
@astirpe
Copy link
Member Author

astirpe commented Nov 21, 2025

Squashed and rebased, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.