[16.0][FIX] github_connector_odoo: Proper manifest and icon load#124
Merged
OCA-git-bot merged 1 commit intoOCA:16.0from Apr 24, 2024
Merged
Conversation
- Internal implementation of get_manifest (with load_file/load_path) was rejecting the manifest path as not being in its addons_path. - Image resizing was not done correctly
chienandalu
approved these changes
Apr 24, 2024
carolinafernandez-tecnativa
approved these changes
Apr 24, 2024
carlosdauden
approved these changes
Apr 24, 2024
Member
Author
|
/ocabot merge patch |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
@pedrobaeza The merge process could not be finalized, because command |
Contributor
|
Congratulations, your PR was merged at 5438e4b. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Tecnativa