Skip to content

[18.0][FIX] edi_core_oca: move ordering inside conditional block #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ricardoalso wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][FIX] edi_core_oca: move ordering inside conditional block #219

Ricardoalso wants to merge 1 commit into from
+2 −2

Conversation

@Ricardoalso
Copy link
Contributor

@Ricardoalso Ricardoalso commented Nov 21, 2025

Fixes major performance issues in edi_exchange_record_view_tree when grouping is enabled. The limit parameter only applies to the number of displayed group lines, but the grouping logic fetches all matching records, causing unnecessary reordering of the entire dataset when set(orig_ids) == set(result).

@Ricardoalso
edi_core_oca: move ordering inside conditional block
8cb471b 
Fixes major performance issues in edi_exchange_record_view_tree when grouping is enabled.
The limit parameter only applies to the number of displayed group lines, but the grouping logic fetches all matching records, causing unnecessary reordering of the entire dataset when set(orig_ids) == set(result).
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 21, 2025

Hi @simahawk, @etobella,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 26, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

simahawk
simahawk reviewed Dec 1, 2025
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit. This goes in conflict w/ #216
I've asked to add tests on that one. If that change is confirmed, this one can be dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk left review comments

+2 more reviewers

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@santostelmo santostelmo santostelmo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ricardoalso @OCA-git-bot @simahawk @cyrilmanuel @santostelmo