Skip to content

[19.0][ADD] website_sale_ribbon#1165

Open
etobella wants to merge 1 commit intoOCA:17.0from
dixmit:17.0-add-ribbon
Open

[19.0][ADD] website_sale_ribbon#1165
etobella wants to merge 1 commit intoOCA:17.0from
dixmit:17.0-add-ribbon

Conversation

@etobella
Copy link
Member

@etobella etobella commented Feb 16, 2026

Odoo defines product.ribbon, but the model and field are hidden to common users from backend

The only way to configure this kind of fields is using debug mode or by the website editor.

With this module, we allow other users to configure this field from backend.

@pedrobaeza
Copy link
Member

AFAIK, this is handled from website editor.

@pedrobaeza pedrobaeza added this to the 17.0 milestone Feb 16, 2026
@etobella etobella changed the title [ADD] website_sale_ribbon [19.0][ADD] website_sale_ribbon Feb 16, 2026
@etobella
Copy link
Member Author

Yes, it is accessible from the products view. However, this change was applied in odoo 19 to simplify the work:

odoo/odoo@b2c5e4e

For giving context of how it is done right now.

image

Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat and LGTM!

@pedrobaeza
Copy link
Member

OK, I see. I sincerely put to everyone base_technical_features and enable for all the users, as this is not the only field you are going to find hidden because they say "it's technical", and doing all these modules for just removing the technical group is too much IMO.

@etobella
Copy link
Member Author

Well, I understand your position, but it has no sense to me for safety reasons. It is true, that users could handle the field in the standard odoo way, and as Odoo changed the behavior un odoo 19, I thought it was a good idea to add the same features in previous versions.

@pedrobaeza
Copy link
Member

OK, as you prefer. That module is totally safe and it's not disclosing any field that compromises the security. On contrary, it prevents to start debug mode for showing business fields and having the debug dropdown with risky options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants