[18.0][MIG] account_credit_control_attach_invoice: Migration to 18.0#464
Conversation
victorvermot
force-pushed
the
18.0-mig_account_credit_control_attach_invoices_bis
branch
from
85cdf00 to
3972a1f
Compare
victorvermot
force-pushed
the
18.0-mig_account_credit_control_attach_invoices_bis
branch
from
3972a1f to
8ab2da1
Compare
yvaucher
left a comment
yvaucher
left a comment
There was a problem hiding this comment.
I'm mostly concerned about the parameter to set which report to attach as it lacks guidance for the user to find it and set it.
A better naming and a clear how to with the exact name of the field string would help is USAGE.rst.
…tional documentation
|
Hi @victorvermot, I created PR to improve documentation a bit (no change on code itself) |
|
@victorvermot Can you add @Kimkhoi3010 changes? |
[IMP] account_credit_control_attach_invoice: improve and clarify functional documentation
|
@yvaucher Done. I also integrated your feedback and changed the string of the field ! Thanks a lot for the pr @Kimkhoi3010 |
victorvermot
force-pushed
the
18.0-mig_account_credit_control_attach_invoices_bis
branch
2 times, most recently
from
8ec5974 to
1ed39d8
Compare
victorvermot
force-pushed
the
18.0-mig_account_credit_control_attach_invoices_bis
branch
from
1ed39d8 to
35d6044
Compare
yvaucher
left a comment
yvaucher
left a comment
There was a problem hiding this comment.
@victorvermot Thanks for the changes
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at f4f9065. Thanks a lot for contributing to OCA. ❤️ |
7 participants
No description provided.