Open
Conversation
Based on the work on OCA#43.
These new classes do nothing by default and will be 'replaced' in the 'magentoerpconnect_catalog_simple' module which will import new fields.
[IMP] import product_attribute_set from magento
Because the number of classes tend to grow fast in connector addons, organize directories using a hierarchy: - models |-- model_name |---- common.py: hold Models, Binders, Adapters (what is shared for importers and exporters) |---- importer.py: hold functions and classes related to imports |---- exporter.py: hold functions and classes related to exports
[IMP] show attribute_set_id field in module catalog_simple
Member
|
Thanks 👍 |
| * vals: field values of the new record, e.g {'field_name': field_value, ...} | ||
| """ | ||
|
|
||
| on_product_write = Event() |
Member
There was a problem hiding this comment.
Those 2 ought to be added in connector_base_product
This was referenced Mar 17, 2016
|
Is someone working on this? |
Member
Author
|
yes me 😄 |
|
Great :) Before going deep on the PR, is it fully functional? |
Member
Author
|
@liebana This one is working for one of our customers. |
|
@damdam-s does it support simple (one attribute - multiple values) variants ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.