[ADD] new module magentoerpconnect_transaction_id#183
Open
[ADD] new module magentoerpconnect_transaction_id#183
Conversation
Author
There was a problem hiding this comment.
@guewen Thank you for the link. I'll introduce a new hook SalePaymentImportMapper to avoid to add a new dependency on base_transaction_id.
1d72db3 to
83c6304
Compare
Member
There was a problem hiding this comment.
Could you give it a more friendly name?
Member
What is your status on that? Tests seem to fail due to a periods error so I guess it is not related to your pull request ( |
83c6304 to
3537515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests fails due to the payment term used in
SetUpMagentoBaseI've removed the payment_term in the tests developed for this new module and the tests are successful.