[8.0] Migration of magentorepconnect_order_comment

[hugosantosred]

Migrated module magentoerpconnect_order_comment to version 8.0 with new API

[guewen]

Help messages are automatically translated, you should not use _() on them.
(I know it was wrong before but it is the right opportunity to correct it)

[guewen]

Only a small remark regarding a correction with _(), apart that, that's fine!

Thanks
👍

[hugosantosred]

I didn't know that about help on fields and translations. Thanks! @guewen

[StefanRijnhart]

On the create method, you need to apply the @api.returns('self', lambda value: value.id) decorator for backwards compatibility with old API overrides of this method (you know, just in case...)

[guewen]

I was sure it was inherited. This comment would tend to confirm that, but it could be wrong https://github.com/odoo/odoo/blob/9.0/openerp/api.py#L77
Had you ever had issues with that?

[StefanRijnhart]

You are right: I can't seem to reproduce any such issues with a quick test. Thanks for the pointer!

[StefanRijnhart]

Can you catch ImportError for the import of bs4 and then at runtime (in a method where you use the import) check if bs4 is defined, and raise then?

try:
    from bs4 import BeautifulSoup
except ImportError:
    BeautifulSoup = False

...

    if not BeautifulSoup:
        raise ....
    return {'comment': BeautifulSoup(comment).get_text()}

[StefanRijnhart]

You seem to miss 0ead0327ecc2, and I think you would need to take the i18n directory as well.