Open
Conversation
cvinh
force-pushed
the
14.0-add_account_budget_oca_analytic_tag
branch
2 times, most recently
from
2745daf to
52ac7ee
Compare
Member
|
@cvinh We will want to separate in 2 PRs. |
cvinh
force-pushed
the
14.0-add_account_budget_oca_analytic_tag
branch
from
52ac7ee to
3a99d68
Compare
cvinh
changed the title
Contributor
Author
Done |
cvinh
force-pushed
the
14.0-add_account_budget_oca_analytic_tag
branch
2 times, most recently
from
16e99c0 to
3176f01
Compare
rvalyi
requested changes
Jun 9, 2023
Member
There was a problem hiding this comment.
two immediate remarks:
- usually this kind of logo is not accepted in the OCA https://github.com/OCA/account-budgeting/pull/58/files#diff-8118393e2174e2ba6b031f266e1e4a8b45697baddc3cd591c01398dc1ccf549e
- I think some tests would be required. The current coverage is at 40% while the repo coverage is at 75%
cvinh
force-pushed
the
14.0-add_account_budget_oca_analytic_tag
branch
9 times, most recently
from
daf9319 to
98a81a7
Compare
cvinh
force-pushed
the
14.0-add_account_budget_oca_analytic_tag
branch
from
98a81a7 to
ef1cfff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Courtesy of @max3903