Skip to content

Support changelog for the new branch model:#160

Open
NvTimLiu wants to merge 3 commits intobranch-25.10from
changelog-new-branch-model
Open

Support changelog for the new branch model:#160
NvTimLiu wants to merge 3 commits intobranch-25.10from
changelog-new-branch-model

Conversation

@NvTimLiu
Copy link
Owner

@NvTimLiu NvTimLiu commented Sep 7, 2025

1, Retrieve commit hashes for a release after enabling the new branch model.

2, Create a query to fetch pull request (PR) information from GitHub using commit hashes.

3, Support retrieving PR changelogs for both the old and new branch models.

@pxLi pxLi requested a review from Copilot September 9, 2025 03:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for changelog generation with a new branch model, transitioning from the old branch-YY.MM pattern to a new release/YY.MM pattern starting from version 25.10. The changes enable the script to handle both branching models and retrieve commit information via GitHub's GraphQL API.

  • Introduces commit-based PR retrieval for the new branch model using GitHub GraphQL queries
  • Adds logic to determine which branch pattern to use based on the release version
  • Implements functions to calculate previous release versions and fetch commits between branches

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

changelog = {} # changelog dict
releases = {x.strip() for x in rels.split(',')}
# Sort releases in descending order for the follow-up operations
releases = sorted(releases, reverse=True)
Copy link

Copilot AI Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converting releases from a set to a sorted list changes its type, but the variable name and usage throughout the codebase still treat it as a set. This could cause issues in functions that expect a set type. Consider using a different variable name like sorted_releases for the sorted list.

Copilot uses AI. Check for mistakes.
@NvTimLiu NvTimLiu force-pushed the changelog-new-branch-model branch from 6c29169 to cb29987 Compare October 15, 2025 09:26
1, Retrieve commit hashes for a release after enabling the new branch model.

2, Create a query to fetch pull request (PR) information from GitHub using commit hashes.

3, Support retrieving PR changelogs for both the old and new branch models.

Signed-off-by: timl <timl@nvidia.com>
@NvTimLiu NvTimLiu force-pushed the changelog-new-branch-model branch from cb29987 to b6beb84 Compare October 15, 2025 11:16
@NvTimLiu
Copy link
Owner Author

image

image

Signed-off-by: timl <timl@nvidia.com>
… the changelog

Signed-off-by: timl <timl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants