fix: encoder not flushing data #434
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, thank you for your work on this library!
after upgrading async-compression, our custom protocol stopped working i.e. receiving responses like for eg, ACKs would get stuck and never reach the client, this happened on release 0.4.33 so i ran git bisect:
good:
b79f66d40697ab7dadf791a416ab2ba15cccc3a3bad:
2aa1b5f8122618004b9bbab6dc679bafca616ff2and
6c0835eb5dd26cb6176acd0455437be13fdaadacbeing the one where this problem happens (#402)i went over the changes and it seemed like the loop exited before setting the counter was set so i set:
and it seemed to work on that commit with my sample code, but then again broken when i applied this change on main, so i ran git bisect again etc comparing against my working version and saw some behavior was changed changing AsyncRead impl back to returning Ready whenever data was written to buffer worked
idk how correct this is, but wanted to try to fix this as it did break things with Tower's compression layer enabled for us when we upgraded deps to move from 0.4.32 -> 0.4.36
happy to work on this further and improve this. appreciate any feedback to fix this (: