Add more details to options during deck direct import #927
Add more details to options during deck direct import #927
Conversation
|
This is killer! |
|
Nice! Are you able to sort printings reverse chronologically? |
|
In term of release date? Should not be complicated |
web/js/directimport.js
Outdated
|
|
||
| // If same title, sort by pack release date reversed | ||
| if (a.title === b.title) { | ||
| const aPackReleaseDate = moment( |
There was a problem hiding this comment.
i don't think you need the moment creation. The date format is already sortable properly as a string.
|
|
||
| // If same title, sort by pack release date reversed | ||
| if (a.title === b.title) { | ||
| return b.pack.date_release.localCompare(a.pack.date_release) |
There was a problem hiding this comment.
this should be localeCompare.
There was a problem hiding this comment.
please adjust the formatter settings you set up. It removed all trailing semicolons, which is a big, unnecessary change and will update a ton of files.
I would recommend not doing the linter / formatter at all in this PR, but as it's own PR so we can evaluate it's settings and impact.
There was a problem hiding this comment.
oh, I didn't realise that it removes the trailing semicolons (which I also don't like). I have prettier installed so it runs by default. I'll revert those changes 🐱
3 participants
This is to handle this issue #915
If there is multiple printing, the option shows what set the card is from (it only change the dropdown, not the actual list)
Example in case of not similar text. If this is too much, please inform so I can modify it
