Made plaintext decklist outputs more friendly to screenreaders#848
Open
distributive wants to merge 1 commit intoNull-Signal-Games:mainfrom
Open
Made plaintext decklist outputs more friendly to screenreaders#848distributive wants to merge 1 commit intoNull-Signal-Games:mainfrom
distributive wants to merge 1 commit intoNull-Signal-Games:mainfrom
Conversation
Contributor
Author
|
My editor added that extra space after the five_threes line. I don't know why. |
Collaborator
|
This makes it better for screen readers and worse for browser users. Let's take a look at how we can get the best of both worlds here. |
Contributor
Author
|
Feel free to edit this |
Contributor
|
Hey @distributive ! We're re-reviewing this issue. Could you share a screen recording of the current inaccessible behavior? It'd help us better understand what this PR is doing |
Contributor
Author
|
Go to the plaintext output of a deck: Note that there is an "x" after the number of each card, that a screen reader will read out: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the plaintext data for decklists would include an
xbefore each card (e.g. "3x Sure Gamble") which screenreaders would read out, making it an inaccessible feature. It also reads out the influence pips individually, so those have been simplified to plaintext.