Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 94.86% 94.86%
=======================================
Files 37 37
Lines 3855 3855
Branches 3855 3855
=======================================
Hits 3657 3657
Misses 171 171
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the dependency management structure by removing dev-dependencies and converting them to optional workspace dependencies. The changes centralize dependency version management at the workspace level and properly gate tests that require optional features.
Changes:
- Introduced workspace-level dependency management for
heck,http, andregexin the rootCargo.toml - Converted dev-dependencies to optional regular dependencies with proper feature gating
- Added feature gate to test that depends on the
heckcrate to ensure it only runs when thecasefeature is enabled
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Added workspace dependencies section with heck, http, and regex versions |
crates/const-str/Cargo.toml |
Removed dev-dependencies section, converted dependencies to workspace references, updated feature definitions to include dep: prefix, reordered metadata section |
crates/const-str-proc-macro/Cargo.toml |
Updated dependencies to use workspace references and sorted them alphabetically |
crates/const-str/src/__ctfe/ascii_case.rs |
Added #[cfg(feature = "case")] gate to test function that uses heck crate |
.github/workflows/ci.yml |
Removed codecov token field from workflow configuration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.