This repository was archived by the owner on May 11, 2025. It is now read-only.
Open
Conversation
…eProjectGateway returns false
…ateway returns true
… thrown in CreateProjectGatewayImpl.create
maikella
suggested changes
Apr 30, 2025
.../main/java/com/nucleo42/infrastructure/controller/common/ValidateFieldsExceptionHandler.java
Outdated
Show resolved
Hide resolved
matheusgondra
suggested changes
Apr 30, 2025
usecase/src/main/java/com/nucleo42/usecase/FindAllProjects.java
Outdated
Show resolved
Hide resolved
application/src/test/java/com/nucleo42/application/usecase/AddProjectImplTest.java
Outdated
Show resolved
Hide resolved
application/src/test/java/com/nucleo42/application/usecase/AddProjectImplTest.java
Outdated
Show resolved
Hide resolved
infrastructure/src/main/java/com/nucleo42/infrastructure/dto/UpdateProjectRequestDTO.java
Show resolved
Hide resolved
infrastructure/src/main/java/com/nucleo42/infrastructure/dto/CreateProjectRequestDTO.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pelo que vi na implementação do Gateway o update está buscando e atualizando. Injeta um FindProjectGateway para buscar o project e o update apenas atualiza esse project encontrado.
There was a problem hiding this comment.
Está faltando os teste dessa classe
infrastructure/src/main/java/com/nucleo42/infrastructure/service/ProjectGateway.java
Show resolved
Hide resolved
matheusgondra
suggested changes
May 1, 2025
infrastructure/src/test/java/com/nucleo42/infrastructure/service/ProjectGatewayTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Falta documentar os parametros que a rota pode receber no swagger
There was a problem hiding this comment.
Está faltando os teste dessa classe
There was a problem hiding this comment.
Está faltando os teste dessa classe
There was a problem hiding this comment.
Está faltando os teste dessa classe
…e in ProjectGateway
…on when id is invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OBS: Adicionei um handler para pegar as validações do Spring Validation, e criei um DTO para retornar erros de uma forma padronizada com todos os campos em uma lista errors: [{ nomeCampo: Erro}, ...], isso se fez necessário para que eu pudesse validar minhas requisições de acordo com o que era inserido.