libbladerf: Increase timeout for waiting on sync_worker_task thread during sync_worker_init. #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vadimart92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1015
The problem is that under certain conditions (this can also be reproduced when the app is unpacked from an archive for the first time—possibly due to antivirus interference?), the 1000 ms timeout is not enough for the thread to set SYNC_WORKER_STATE_IDLE.
As a result, the method returns BLADERF_ERR_TIMEOUT and calls free(s->worker). However, after this, the sync_worker_task thread still executes, leading to an access violation and ultimately causing the application to crash.