attempt at a fix for msbuild-12580 #7033
Open
+263
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
Community
jeffkl
reviewed
Jan 7, 2026
| /// when trying to write to the same .nupkg file. | ||
| /// </summary> | ||
| [PlatformFact(Platform.Windows)] | ||
| public void PackCommand_MultiTargetedProject_WithGraphMode_Succeeds() |
Contributor
There was a problem hiding this comment.
Were you able to verify that without your fix that the test fails?
Author
There was a problem hiding this comment.
I have a local verification, but it is surprisingly annoying to get it to fail in the integration tests.
work in progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: dotnet/msbuild#12580
Description
When running the reproduction as described in the linked issue, the first time around the build fails due to a file being locked.
This is an attempt to remedy the issue by only running the target in the inner build. This is consistent with how _PackAsBuildAfterTarget already handles the GeneratePackageOnBuild scenario (lines 164-165):
PR Checklist