Ella via Elementary: Update accepted_values test error threshold to > 100 rows #305
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rows\n\nAdded model configuration for 'one' model with accepted_values test\nthat has error_if uncommented and set to '> 100' instead of '!= 0'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary\n\nThis PR updates the accepted_values test on the⚠️ Warn if > 2 invalid rows are found \n- ❌ Fail only if > 100 invalid rows are found\n\nThis makes the test more tolerant of data quality issues while still providing early warning signals.\n"
onecolumn of theonemodel to:\n\n1. Uncomment the error_if condition as requested\n2. Change the error threshold from!= 0to> 100\n\n## Changes\n\n- Added model configuration for theonemodel inmodels/schema.yml\n- Set the accepted_values test to:\n -values: [2, 3](unchanged)\n -error_if: \"> 100\"(uncommented and updated threshold)\n -warn_if: \"> 2\"(keeping existing warn condition)\n\n## Impact\n\nWith this change, the test will:\n- ✅ Pass if ≤ 100 invalid rows are found\n-Created by:
ella+123@elementary-data.com