Open
Conversation
Owner
Nox-MSFT
commented
Feb 21, 2023
Nox-MSFT
commented
- Use separate ('configs') folder for sdk-config.json file. (This is optional)
- Create content-download-folder plug that can be used for sharing content between DO and DU snap
- [For testing purposes] Add 'sdk' part in DO snap, so that we can use it for sdk installation, if needed.
| const std::string& GetSDKConfigFilePath() | ||
| { | ||
| #ifdef DO_BUILD_FOR_SNAP | ||
| static std::string configFilePath(DO_CONFIG_DIRECTORY_PATH "/configs/sdk-config.json"); |
There was a problem hiding this comment.
I would rather not have different paths like this. Instead, I think it is ok to allow write access to the entire /etc/deliveryoptimization-agent folder.
| - libssh-4 | ||
| - libwind0-heimdal | ||
|
|
||
| sdk: |
There was a problem hiding this comment.
Don't think we should be including deb file within the snap. Since the recommendation is for DU to include the libDO.so in its own snap, let's keep this snapcraft file for the DO agent alone.
Owner
Author
There was a problem hiding this comment.
Agreed. This is for testing purposes only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.