Conversation
|
Deployment failed with the following error: Learn More: https://vercel.com/nowelys-projects?upgradeToPro=build-rate-limit |
Nowely
changed the title
- Refactor typecheck scripts across multiple packages to standardize usage. - Update package links in pnpm-lock.yaml to point to the 'dist' directory for better module resolution. - Add TypeScript and Vue typecheck scripts to respective package.json files for improved type safety.
…ory references - Adjusted package links for '@markput/react' and '@markput/vue' to point directly to the parent directory instead of the 'dist' subdirectory. - Removed unnecessary package entries for 'packages/react/markput/dist' and 'packages/vue/markput/dist' to streamline the lock file.
Nowely
pushed a commit
that referenced
this pull request
Mar 7, 2026
🤖 I have created a release *beep* *boop* --- ## [0.5.0](0.4.0...0.5.0) (2026-03-07) ### Features * **core:** add ContentEditableController for DOM-based editing ([#134](#134)) ([633133b](633133b)) ### Refactoring * extract shared logic from framework adapters to core ([#145](#145)) ([795c0e8](795c0e8)) * improve Signal typing with interface augmentation for framework-specific use() return types ([#143](#143)) ([e6d4efc](e6d4efc)) ### Miscellaneous * migrate to pnpm catalog for centralized dependency management ([#140](#140)) ([b71cd55](b71cd55)) * update oxlint configuration ([#144](#144)) ([1db73ec](1db73ec)) ### Tests * add comprehensive Vue component tests with Vitest ([#142](#142)) ([231f3dc](231f3dc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
VueStoremapped type approach with TypeScript module augmentation on theSignal<T>interface, allowing each framework adapter to override the return type ofuse()without polluting the core types.defineState.ts): ConvertsSignal<T>from a type alias to aninterface(enabling augmentation), and changesuse()from a property to a method signature.UseHookFactoryreturn type is relaxed tounknown.Store.ts): Uses the newStateObject<MarkputState>alias (cleaner thanReturnType<typeof defineState<...>>).useStore.ts): Adds adeclare module '@markput/core'block that augmentsSignal<T>souse()returnsRef<T>— Vue components now get properRef<T>types without casting.Motivation
The previous approach required maintaining a parallel
VueStoremapped type that mirroredStore.statewithRef-wrapped values. This PR eliminates that duplication by letting TypeScript's module augmentation handle the per-framework narrowing at the source.