Merged
Conversation
Member
matthew-phelps
left a comment
There was a problem hiding this comment.
See my one comment, otherwise GTG
Mannequin
Github pagesReview the pkgdown webpage for the PR here |
matthew-phelps
approved these changes
Dec 4, 2025
Mannequin
Code coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Summary
Updated all internal example and tests templates to use
{{domain}}instead of.self.This PR is not optimal in the sense that the testing framework will be updated in #48, which means there are some quick fixes here that will be replaced very soon.
I considered implementing the
{{domain}}in #48 as well, but thought it was better to keep it separate, even if this update is necessary for the unit test development to continue.Changes Made
inst/components. Implemented{{domain}}as param.tests/testthat/_componentsinputargument frommsr_test(). Using a temporaryvalue = "domain"right now to test it. Will be completely replaced in the above mentioned PR.Testing
domainas rendering parameterinst/componentsdue to the testing framework being updated as well. Once updated, these should pass.expect_ady()function intest-component.Rto reduce copy-paste code.Checklist