Fix cb respawn logic #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit attempts to **simulate** vanilla respawn logic by calling methods originally called in constructors, as CraftBukkit respawn logic reuses player instance instead of creating a new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to simulate vanilla respawn logic by calling methods originally called in constructors, as CraftBukkit respawn logic reuses player instance instead of creating a new one.
Some mods re-register DataParameter on ConstructEvent, the previous fix will cause IllegalStateException issues if mods do not check the param has been already registered.
The new fix captures all vanilla data values, clear DataManager then restore vanilla data values.
Download the test jars here: