fix(config): reload .env over stale shell overrides#1434
Merged
Conversation
Hermes startup entrypoints now load ~/.hermes/.env and project fallback env files with user config taking precedence over stale shell-exported values. This makes model/provider/base URL changes in .env actually take effect after restarting Hermes. Adds a shared env loader plus regression coverage, and reproduces the original bug case where OPENAI_BASE_URL and HERMES_INFERENCE_PROVIDER remained stuck on old shell values before import.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.hermes/.envoverride stale shell-exported values on restart.envfill missing values in dev setupsRoot cause
I reproduced the issue directly on current main:
OPENAI_BASE_URL=https://old.example/v1~/.hermes/.envcontainedOPENAI_BASE_URL=https://new.example/v1andHERMES_INFERENCE_PROVIDER=customhermes_cli.mainleft the old shell values in place because the startup dotenv loads were using the defaultoverride=FalseThat meant editing
.envand restarting Hermes could still leave the process pinned to old model/provider/base_url settings if those vars were already exported in the parent shell.Test plan
Verification
PYTHONPATH=. python /tmp/repro1244.pynow prints the updated values from the Hermes user env file instead of the stale shell exports